Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 107403002: Add debugging prints to the Mac OS directory watcher. (Closed)

Created:
7 years ago by nweiz
Modified:
7 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add debugging prints to the Mac OS directory watcher. This is a temporary CL that will make it easier to track down and fix the errors in the mac watcher. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30919

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -5 lines) Patch
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 1 10 chunks +91 lines, -5 lines 0 comments Download
M pkg/watcher/test/directory_watcher/mac_os_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/watcher/test/utils.dart View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years ago (2013-12-05 22:39:30 UTC) #1
Bob Nystrom
One question, otherwise LGTM. https://codereview.chromium.org/107403002/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/107403002/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode37 pkg/watcher/lib/src/directory_watcher/mac_os.dart:37: super(directory, () => new _MacOSDirectoryWatcher(directory, ...
7 years ago (2013-12-05 22:43:54 UTC) #2
nweiz
https://codereview.chromium.org/107403002/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/107403002/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode37 pkg/watcher/lib/src/directory_watcher/mac_os.dart:37: super(directory, () => new _MacOSDirectoryWatcher(directory, _count)); On 2013/12/05 22:43:55, ...
7 years ago (2013-12-05 22:48:47 UTC) #3
nweiz
7 years ago (2013-12-05 22:49:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698