Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1073993004: Revert "Issue 23133. Fix for restoring 'package:' uris on Windows." (Closed)

Created:
5 years, 8 months ago by ricow1
Modified:
5 years, 8 months ago
Reviewers:
Bill Hesse, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Issue 23133. Fix for restoring 'package:' uris on Windows." This reverts revision 45023 It is my strong suspicion that this is causing the redness here: http://build.chromium.org/p/client.dart/builders/pub-win-russian-be/builds/3729/steps/pub%20and%20pkg%20%20tests%20failures/logs/stdio R=scheglov@google.com, whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M pkg/analyzer/lib/source/package_map_resolver.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
5 years, 8 months ago (2015-04-10 05:55:22 UTC) #1
ricow1
tbr
5 years, 8 months ago (2015-04-10 05:55:35 UTC) #2
ricow1
Committed patchset #1 (id:1) manually as 45049 (presubmit successful).
5 years, 8 months ago (2015-04-10 05:55:59 UTC) #3
Bill Hesse
lgtm
5 years, 8 months ago (2015-04-10 06:07:27 UTC) #4
scheglov
5 years, 8 months ago (2015-04-10 15:22:27 UTC) #5
Message was sent while issue was closed.
Rico, you are right, it is the reason of this failure.
LGTM

Powered by Google App Engine
This is Rietveld 408576698