Create a public API for contributing assists and make assists pluggable

Create a public API for contributing assists and make assists pluggable

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45109

[Brian Wilkerson, 2015-04-11 00:16:33]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-04-11 00:25:02]

LGTM

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:124: CompilationUnitElement
element = unit.element;
If we don't actually use CompilationUnit here (and for fixes), it might be
cleaner to use AnalysisServer.getContextSourcePair() instead.

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist.dart (right):

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist.dart:21: List<Assist>
fixes = <Assist>[];
assists

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist.dart:25: List<Assist>
contributedFixes =
contributedAssists

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist.dart:32: 'Exception from
fix contributor: ${contributor.runtimeType}',
assist contributor

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1912: * as
a fix contributor.
assist

[Brian Wilkerson, 2015-04-13 15:17:58]

PTAL

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:124: CompilationUnitElement
element = unit.element;
> If we don't actually use CompilationUnit here (and for fixes), it might be
> cleaner to use AnalysisServer.getContextSourcePair() instead.

I've made the change here, we can clean up getFixes later.

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist.dart (right):

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist.dart:21: List<Assist>
fixes = <Assist>[];
Done

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist.dart:25: List<Assist>
contributedFixes =
Done

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist.dart:32: 'Exception from
fix contributor: ${contributor.runtimeType}',
Done

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/1073383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1912: * as
a fix contributor.
Done

[scheglov, 2015-04-13 15:58:35]

LGTM

[Brian Wilkerson, 2015-04-13 16:04:04]

Committed patchset #2 (id:20001) manually as 45109 (presubmit successful).