Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1073343003: Avoid restoring the outer saved try context when inside a finally. (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid restoring the outer saved try context when inside a finally. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=45083

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M runtime/vm/parser.cc View 1 10 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 8 months ago (2015-04-10 23:03:54 UTC) #2
hausner
LGTM. As discussed offline, it may be a bit confusing that the flag is in ...
5 years, 8 months ago (2015-04-10 23:16:26 UTC) #3
regis
On 2015/04/10 23:16:26, hausner wrote: > LGTM. As discussed offline, it may be a bit ...
5 years, 8 months ago (2015-04-10 23:23:48 UTC) #4
regis
5 years, 8 months ago (2015-04-10 23:24:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698