Issue 107333003: Fix an old TODO.

Issue 107333003: Fix an old TODO. (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix an old TODO. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31253

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -127 lines)			Patch
M	runtime/lib/array.dart	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
D	sdk/lib/_collection_dev/arrays.dart	View		1 chunk	+0 lines, -100 lines	0 comments	Download
M	sdk/lib/_collection_dev/collection_dev.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_collection_dev/collection_dev_sources.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_collection_dev/iterable.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	sdk/lib/_collection_dev/lists.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_array.dart	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

I think the Arrays class is also used in: runtime/lib/array.dart runtime/lib/growable_array.dart sdk/lib/_internal/lib/js_array.dart They should also ...

7 years ago (2013-12-11 09:06:03 UTC) #3

floitsch

https://codereview.chromium.org/107333003/diff/1/sdk/lib/_collection_dev/lists.dart File sdk/lib/_collection_dev/lists.dart (right): https://codereview.chromium.org/107333003/diff/1/sdk/lib/_collection_dev/lists.dart#newcode1 sdk/lib/_collection_dev/lists.dart:1: // Copyright (c) 2012, the Dart project authors. Please ...

7 years ago (2013-12-11 09:06:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31253 (presubmit successful).

Expand Messages | Collapse Messages