Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1073273002: dart2js: Fix csp minified. (Closed)

Created:
5 years, 8 months ago by floitsch
Modified:
5 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Fix csp minified. For the most part this only required status file or test updates. There was, however, a bug in the code that extracted the class-name from its constructor. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45084

Patch Set 1 #

Patch Set 2 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/canvas_pixel_array_type_alias_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
I couldn't look at the diffs (don't know why), but the full diff (raw download) ...
5 years, 8 months ago (2015-04-10 19:03:28 UTC) #2
sra1
lgtm
5 years, 8 months ago (2015-04-10 22:52:05 UTC) #3
floitsch
5 years, 8 months ago (2015-04-13 07:50:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698