Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1073173003: Eliminate object table and use regular object pool for deoptimization infos. (Closed)

Created:
5 years, 8 months ago by Florian Schneider
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Eliminate object table and use regular object pool for deoptimization infos. On platforms that already use an object pool, we had a separate object table used only for deoptimization infos. With this CL we don't have separate tables, but only use the common object pool for both purposes. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45108

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : addressed comments #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -68 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/assembler_ia32.h View 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 chunks +6 lines, -13 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 5 chunks +6 lines, -10 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 4 chunks +7 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 2 chunks +4 lines, -9 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/raw_object.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 8 months ago (2015-04-13 12:12:48 UTC) #2
Vyacheslav Egorov (Google)
LGTM https://codereview.chromium.org/1073173003/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1073173003/diff/20001/runtime/vm/compiler.cc#newcode723 runtime/vm/compiler.cc:723: graph_compiler.FinalizeDeoptInfo(&assembler)); Maybe add a comment that FinalizeDeoptInfo populates ...
5 years, 8 months ago (2015-04-13 15:31:37 UTC) #3
Florian Schneider
https://codereview.chromium.org/1073173003/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1073173003/diff/20001/runtime/vm/compiler.cc#newcode723 runtime/vm/compiler.cc:723: graph_compiler.FinalizeDeoptInfo(&assembler)); On 2015/04/13 15:31:37, Vyacheslav Egorov (Google) wrote: > ...
5 years, 8 months ago (2015-04-13 15:37:27 UTC) #4
Florian Schneider
5 years, 8 months ago (2015-04-13 15:44:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r45108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698