Issue 107293008: Fixes bug in far branches on MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107293008: Fixes bug in far branches on MIPS. (Closed)

Created:
7 years ago by zra

Modified:
7 years ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes bug in far branches on MIPS. Also increases test coverage of far branches on ARM and MIPS. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=31024

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+429 lines, -4 lines)			Patch
M	runtime/vm/assembler_arm.h	View	2 chunks	+6 lines, -1 line	1 comment	Download
M	runtime/vm/assembler_arm_test.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View	7 chunks	+372 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zra

This is the fix for: https://code.google.com/p/dart/issues/detail?id=15275

7 years ago (2013-12-09 23:31:39 UTC) #1

srdjan

7 years ago (2013-12-10 18:02:24 UTC) #5

Message was sent while issue was closed.

LGTM with comment

https://codereview.chromium.org/107293008/diff/1/runtime/vm/assembler_arm.h
File runtime/vm/assembler_arm.h (right):

https://codereview.chromium.org/107293008/diff/1/runtime/vm/assembler_arm.h#n...
runtime/vm/assembler_arm.h:326: void set_use_far_branches(bool b) {
Add comment: to be used by tests only.  It is quite a dangerous function ...

Expand Messages | Collapse Messages