Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1072443005: Deal with type arguments of generic local functions in VM mirrors. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Deal with type arguments of generic local functions in VM mirrors. BUG=http://dartbug.com/14913 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=44983

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -44 lines) Patch
M runtime/lib/mirrors.cc View 1 2 11 chunks +49 lines, -22 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 2 10 chunks +14 lines, -18 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-08 20:49:17 UTC) #2
regis
LGTM https://codereview.chromium.org/1072443005/diff/20001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/1072443005/diff/20001/runtime/lib/mirrors_impl.dart#newcode1360 runtime/lib/mirrors_impl.dart:1360: final _instantiatorForLocal; I do not understand the meaning ...
5 years, 8 months ago (2015-04-08 20:58:07 UTC) #3
rmacnak
https://codereview.chromium.org/1072443005/diff/20001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/1072443005/diff/20001/runtime/lib/mirrors_impl.dart#newcode1360 runtime/lib/mirrors_impl.dart:1360: final _instantiatorForLocal; On 2015/04/08 20:58:06, regis wrote: > I ...
5 years, 8 months ago (2015-04-08 21:35:05 UTC) #4
regis
LGTM
5 years, 8 months ago (2015-04-08 21:38:06 UTC) #5
rmacnak
5 years, 8 months ago (2015-04-08 21:40:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 44983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698