Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1072423003: When attempting to navigate to a page for an isolate that doesn't exist, offer to (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

When attempting to navigate to a page for an isolate that doesn't exist, offer to visit the same page for the each of the isolates that currently exist. - Remove trailing slash from vm-connect page for uniformity with other pages - Fix script-inset sizing. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=45472

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -23 lines) Patch
M runtime/observatory/lib/elements.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/location_manager.dart View 1 3 chunks +31 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 3 chunks +33 lines, -7 lines 2 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/lib/src/elements/isolate_reconnect.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate_reconnect.html View 1 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/observatory_element.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.html View 1 chunk +2 lines, -2 lines 1 comment Download
M runtime/observatory/observatory_sources.gypi View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
https://codereview.chromium.org/1072423003/diff/20001/runtime/observatory/lib/src/app/page.dart File runtime/observatory/lib/src/app/page.dart (right): https://codereview.chromium.org/1072423003/diff/20001/runtime/observatory/lib/src/app/page.dart#newcode69 runtime/observatory/lib/src/app/page.dart:69: return app.vm.getIsolate(isolateId).then((isolate) { Probably push this into the service ...
5 years, 8 months ago (2015-04-23 18:32:19 UTC) #2
turnidge
LGTM w/ 1 small comment... https://codereview.chromium.org/1072423003/diff/20001/runtime/observatory/lib/src/app/page.dart File runtime/observatory/lib/src/app/page.dart (right): https://codereview.chromium.org/1072423003/diff/20001/runtime/observatory/lib/src/app/page.dart#newcode69 runtime/observatory/lib/src/app/page.dart:69: return app.vm.getIsolate(isolateId).then((isolate) { On ...
5 years, 7 months ago (2015-05-01 17:23:56 UTC) #3
rmacnak
5 years, 7 months ago (2015-05-01 18:39:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45472 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698