dart2js: fully assemble program before emitting it.

dart2js: fully assemble program before emitting it.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45237

Reverted: https://code.google.com/p/dart/source/detail?r=45239

Committed: https://code.google.com/p/dart/source/detail?r=45276

[herhut, 2015-04-17 11:13:15]

herhut@google.com changed reviewers:
+ karlklose@google.com

[herhut, 2015-04-17 11:13:45]

This is a prerequisite to analyzing all generated JS on the AST level before
emission.

[karlklose, 2015-04-17 11:26:10]

LGTM.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:460: Fragment fragment)
{
Align parameter.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1006: String
constructorName,
Align parameters.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1071:
assemblePrecompiledConstructor(mainOutputUnit,
Align arguments.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1629: return
elementDescriptors.putIfAbsent(
How about formatting this as:
  return elementDescriptors.putIfAbsent(
      fragment, () => new Map<Element, ClassBuilder>())
      .putIfAbsent(owner, () => new ClassBuilder(owner, namer));

[herhut, 2015-04-17 11:37:31]

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:460: Fragment fragment)
{
On 2015/04/17 11:26:10, karlklose wrote:
> Align parameter.

Done.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1006: String
constructorName,
On 2015/04/17 11:26:10, karlklose wrote:
> Align parameters.

Done.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1071:
assemblePrecompiledConstructor(mainOutputUnit,
On 2015/04/17 11:26:10, karlklose wrote:
> Align arguments.

Done.

https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1629: return
elementDescriptors.putIfAbsent(
On 2015/04/17 11:26:10, karlklose wrote:
> How about formatting this as:
>   return elementDescriptors.putIfAbsent(
>       fragment, () => new Map<Element, ClassBuilder>())
>       .putIfAbsent(owner, () => new ClassBuilder(owner, namer));

How about this one?

[herhut, 2015-04-17 11:48:04]

Committed patchset #2 (id:20001) manually as 45237 (presubmit successful).

[karlklose, 2015-04-17 11:50:25]

On 2015/04/17 11:37:31, herhut wrote:
>
https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
> File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):
> 
>
https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
> pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:460: Fragment
fragment)
> {
> On 2015/04/17 11:26:10, karlklose wrote:
> > Align parameter.
> 
> Done.
> 
>
https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
> pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1006: String
> constructorName,
> On 2015/04/17 11:26:10, karlklose wrote:
> > Align parameters.
> 
> Done.
> 
>
https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
> pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1071:
> assemblePrecompiledConstructor(mainOutputUnit,
> On 2015/04/17 11:26:10, karlklose wrote:
> > Align arguments.
> 
> Done.
> 
>
https://codereview.chromium.org/1072403005/diff/1/pkg/compiler/lib/src/js_emi...
> pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1629: return
> elementDescriptors.putIfAbsent(
> On 2015/04/17 11:26:10, karlklose wrote:
> > How about formatting this as:
> >   return elementDescriptors.putIfAbsent(
> >       fragment, () => new Map<Element, ClassBuilder>())
> >       .putIfAbsent(owner, () => new ClassBuilder(owner, namer));
> 
> How about this one?

Also looks good to me.

[herhut, 2015-04-17 13:31:01]

PTAL, minor fix.

[karlklose, 2015-04-17 13:33:25]

Fix LGTM.

[herhut, 2015-04-20 10:44:03]

Committed patchset #4 (id:60001) manually as 45276 (presubmit successful).