Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 107193006: Remove unused expired certificate, and database, from pub. (Closed)

Created:
7 years ago by Bill Hesse
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unused expired certificate, and database, from pub. BUG=dartbug.com/15364 R=kustermann@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31189

Patch Set 1 #

Patch Set 2 : Patch create_sdk.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M sdk/lib/_internal/pub/lib/src/http.dart View 2 chunks +1 line, -9 lines 0 comments Download
D sdk/lib/_internal/pub/resource/certs/cert9.db View Binary file 0 comments Download
D sdk/lib/_internal/pub/resource/certs/key4.db View Binary file 0 comments Download
D sdk/lib/_internal/pub/resource/certs/pkcs11.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/create_sdk.py View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
Can the resources directory be removed, or is it needed for 7zip on Windows? The ...
7 years ago (2013-12-16 15:25:21 UTC) #1
nweiz
lgtm It's probably safe to delete the resource directory if you modify tools/create_sdk.py so that ...
7 years ago (2013-12-16 19:49:17 UTC) #2
Bill Hesse
Added patch to create_sdk.py.
7 years ago (2013-12-17 10:27:25 UTC) #3
kustermann
lgtm
7 years ago (2013-12-17 12:44:22 UTC) #4
Bill Hesse
7 years ago (2013-12-17 13:19:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r31189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698