Issue 1071853002: Improve error handling of JS-calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1071853002: Improve error handling of JS-calls (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Improve error handling of JS-calls - Accept juxtaposed strings for JS behavior since that can now be large. - Give proper errors rather than scary internal errors. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45013 Reverted: https://code.google.com/p/dart/source/detail?r=45021 Committed: https://code.google.com/p/dart/source/detail?r=45022

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -50 lines)			Patch
	M	pkg/compiler/lib/src/native/behavior.dart	View	2	15 chunks	+57 lines, -48 lines	0 comments	Download
	M	tests/compiler/dart2js/js_spec_string_test.dart	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

sra1

Committed patchset #1 (id:1) manually as 45013 (presubmit successful).

5 years, 8 months ago (2015-04-09 15:55:38 UTC) #4

sra1

Committed patchset #2 (id:20001) manually as 45021 (presubmit successful).

5 years, 8 months ago (2015-04-09 18:07:51 UTC) #5

sra1

5 years, 8 months ago (2015-04-09 18:20:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 45022 (presubmit successful).