Add vmservice_dartium.dart script

Add vmservice_dartium.dart script

BUG=
R=jacobr@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30922

[Jacob, 2013-12-05 23:05:54]

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h
File runtime/bin/resources.h (right):

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h#newc...
runtime/bin/resources.h:11: // Map from Dartium to Dart VM.
Dartium --> Blink

[Cutch, 2013-12-05 23:08:49]

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h
File runtime/bin/resources.h (right):

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h#newc...
runtime/bin/resources.h:11: // Map from Dartium to Dart VM.
On 2013/12/05 23:05:54, Jacob wrote:
> Dartium --> Blink

Done.

[Jacob, 2013-12-05 23:09:52]

On 2013/12/05 23:08:49, Cutch wrote:
> https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h
> File runtime/bin/resources.h (right):
> 
>
https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h#newc...
> runtime/bin/resources.h:11: // Map from Dartium to Dart VM.
> On 2013/12/05 23:05:54, Jacob wrote:
> > Dartium --> Blink
> 
> Done.

lgtm

[Cutch, 2013-12-05 23:30:48]

Committed patchset #2 manually as r30922 (presubmit successful).

[siva, 2013-12-06 00:04:17]

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h
File runtime/bin/resources.h (right):

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h#newc...
runtime/bin/resources.h:15: 
Not sure I understand this. Is "bin/resources.h" now included in dartium?

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
File runtime/bin/vmservice/vmservice_dartium.dart (right):

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_dartium.dart:16: void postResponse(String
response, int cookie) native "PostResponse";
Can the name PostResponse be qualified as
"vmservice_PostResponse" or something like that, that would be in line with
native methods in other files:

e.g:
  Node get firstChild native "Node_firstChild_Getter";
in class Node {
   ....
}

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_dartium.dart:29: }).catchError((e) { });
should the catchError case also post an error response?

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_dartium.dart:56: }
In the above code we seem to ignore invalid messages but in handleRequest we
post an Error response when we get an invalid request, why this divergence?

[Cutch, 2013-12-06 01:36:08]

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h
File runtime/bin/resources.h (right):

https://codereview.chromium.org/107173003/diff/1/runtime/bin/resources.h#newc...
runtime/bin/resources.h:15: 
On 2013/12/06 00:04:18, siva wrote:
> Not sure I understand this. Is "bin/resources.h" now included in dartium?

We are using the generate_resources.py script to bake the vmservice dart files
into dartium. We can move the script and the header into the VM at some point.

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
File runtime/bin/vmservice/vmservice_dartium.dart (right):

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_dartium.dart:16: void postResponse(String
response, int cookie) native "PostResponse";
On 2013/12/06 00:04:18, siva wrote:
> Can the name PostResponse be qualified as
> "vmservice_PostResponse" or something like that, that would be in line with
> native methods in other files:
> 
> e.g:
>   Node get firstChild native "Node_firstChild_Getter";
> in class Node {
>    ....
> }

Agreed. I'm doing this in a cleanup CL that I will CC you on.

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_dartium.dart:29: }).catchError((e) { });
On 2013/12/06 00:04:18, siva wrote:
> should the catchError case also post an error response?

The only way for catchError to trigger would be if the call to the native method
resulted in an error. At that point we can't send an error response.

https://codereview.chromium.org/107173003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_dartium.dart:56: }
On 2013/12/06 00:04:18, siva wrote:
> In the above code we seem to ignore invalid messages but in handleRequest we
> post an Error response when we get an invalid request, why this divergence?

This code is verifying that the data from the embedder is valid. We error check
on the embedder side as well. We could probably get rid of these checks.