Add start/end to Uri.parse, allowing you to parse a substring without creating a new String object.

Add start/end to Uri.parse, allowing you to parse a substring without creating a new String object.

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44993

[Lasse Reichstein Nielsen, 2015-04-08 13:04:50]

lrn@google.com changed reviewers:
+ sgjesse@google.com

[Lasse Reichstein Nielsen, 2015-04-08 13:04:51]

Will add tests too.

[Lasse Reichstein Nielsen, 2015-04-09 06:54:47]

Tests added, ptal.

[Søren Gjesse, 2015-04-09 07:04:42]

lgtm

https://codereview.chromium.org/1071573002/diff/20001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (left):

https://codereview.chromium.org/1071573002/diff/20001/sdk/lib/core/uri.dart#o...
sdk/lib/core/uri.dart:379: int numberSignIndex = uri.indexOf('#', index + 1);
We could add an optional end to indexOf as well...

[Lasse Reichstein Nielsen, 2015-04-09 07:52:03]

https://codereview.chromium.org/1071573002/diff/20001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (left):

https://codereview.chromium.org/1071573002/diff/20001/sdk/lib/core/uri.dart#o...
sdk/lib/core/uri.dart:379: int numberSignIndex = uri.indexOf('#', index + 1);
I actually thought about that, but it doesn't work very well with the Pattern
class. The only method there is allMatches which only has a start, not an end. 

If we could add "end" to Pattern.allMatches, then it would be great then we can
also add "end" to String.indexOf (and probably more), but I guess that's one of
those "potentially future backwards incompatible changes".

[Lasse Reichstein Nielsen, 2015-04-09 08:03:42]

Committed patchset #2 (id:20001) manually as 44993 (presubmit successful).