Issue 107153004: Make sure we mark all depending commands (transitively!) UnableToRun if a command fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107153004: Make sure we mark all depending commands (transitively!) UnableToRun if a command fails (Closed)

Created:
7 years ago by kustermann

Modified:
7 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make sure we mark all depending commands (transitively!) UnableToRun if a command fails R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31241

Patch Set 2 : Addressed comments #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -18 lines)			Patch
	M	dart/tools/testing/dart/test_runner.dart	View	1	2 chunks	+22 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/107153004/diff/10001/dart/tools/testing/dart/test_runner.dart File dart/tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/107153004/diff/10001/dart/tools/testing/dart/test_runner.dart#newcode1820 dart/tools/testing/dart/test_runner.dart:1820: if (allDependenciesSuccessful) { We could compute "anyDependencyUnsuccessful" instead, even ...

7 years ago (2013-12-18 17:18:02 UTC) #2

kustermann

7 years ago (2013-12-18 21:55:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r31241 (presubmit successful).

Expand Messages | Collapse Messages

Issue 107153004: Make sure we mark all depending commands (transitively!) UnableToRun if a command fails (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages