dart2js: create a 'types' table for each deferred unit.

dart2js: create a 'types' table for each deferred unit.

This fixes part of dartbug.com/22995.

R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45061

[zarah, 2015-04-09 12:26:18]

zarah@google.com changed reviewers:
+ floitsch@google.com, sigurdm@google.com

[sigurdm, 2015-04-09 13:00:15]

LGTM

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:683:
addProperty(namer.functionTypeTag, js.number(1));
Add comment explaining this.

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:402:
$setupProgramName(hunk[0], ${typesAccess}.length);
Why not 

  $setupProgramName(hunk[0], #typesAccess.length);

and then let typesAccess be a js_ast expression?
That would eliminate the need for `generateEmbeddedGlobalAccessString`

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:585: throw 'Unexpected
value in ${listAccess}: '
Make this an assert

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:591:
output.add('];$n');
Again here you could let listaccess be a js-expression and then first build the
list and then do something like:
output.add(js.prettyPrint(js.js.statement("# = #;", listAccess, list),
compiler));

[zarah, 2015-04-10 10:56:03]

Thanks. If you want, you can take a quick look. I will run some tests before
committing.

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:683:
addProperty(namer.functionTypeTag, js.number(1));
On 2015/04/09 13:00:15, sigurdm wrote:
> Add comment explaining this.

Done.

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:402:
$setupProgramName(hunk[0], ${typesAccess}.length);
On 2015/04/09 13:00:15, sigurdm wrote:
> Why not 
> 
>   $setupProgramName(hunk[0], #typesAccess.length);
> 
> and then let typesAccess be a js_ast expression?
> That would eliminate the need for `generateEmbeddedGlobalAccessString`

Done.

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:585: throw 'Unexpected
value in ${listAccess}: '
On 2015/04/09 13:00:15, sigurdm wrote:
> Make this an assert

Changed the code. See below.

https://codereview.chromium.org/1071133002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:591:
output.add('];$n');
On 2015/04/09 13:00:15, sigurdm wrote:
> Again here you could let listaccess be a js-expression and then first build
the
> list and then do something like:
> output.add(js.prettyPrint(js.js.statement("# = #;", listAccess, list),
> compiler));

Done.

[sigurdm, 2015-04-10 11:07:53]

https://codereview.chromium.org/1071133002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1071133002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/runtime_types.dart:685:
addProperty(namer.functionTypeTag, js.number(1));
You could also explain why the number 1. I guess it is just a shortest possible
dummy value?

[sigurdm, 2015-04-10 11:09:49]

Still LGTM

[zarah, 2015-04-10 11:21:25]

Committed patchset #4 (id:60001) manually as 45061 (presubmit successful).

[zarah, 2015-04-10 13:32:51]

https://codereview.chromium.org/1071133002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1071133002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/runtime_types.dart:685:
addProperty(namer.functionTypeTag, js.number(1));
On 2015/04/10 11:07:53, sigurdm wrote:
> You could also explain why the number 1. I guess it is just a shortest
possible
> dummy value?

yes, updated comment.