Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 107113007: Fix checked mode errors in InternetAddress test (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix checked mode errors in InternetAddress test R=ajohnsen@google.com BUG=http://dartbug.com/15687 Committed: https://code.google.com/p/dart/source/detail?r=31222

Patch Set 1 #

Patch Set 2 : Removed analyzer expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
A + tests/standalone/io/internet_address_invalid_arguments_test.dart View 1 chunk +11 lines, -8 lines 0 comments Download
M tests/standalone/io/internet_address_test.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years ago (2013-12-18 12:04:37 UTC) #1
Søren Gjesse
Removed the analyzer expectation
7 years ago (2013-12-18 12:14:34 UTC) #2
Anders Johnsen
lgtm
7 years ago (2013-12-18 12:19:10 UTC) #3
Søren Gjesse
7 years ago (2013-12-18 12:20:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r31222 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698