Issue 107103007: Emit a compile-time error for initializers of the form this.foo and super.foo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107103007: Emit a compile-time error for initializers of the form this.foo and super.foo. (Closed)

Created:
7 years ago by karlklose

Modified:
7 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit a compile-time error for initializers of the form this.foo and super.foo. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31219

Patch Set 2 : Improved test. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	A	tests/language/illegal_initializer_test.dart	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM (after verifying that this is a compile-time error). https://codereview.chromium.org/107103007/diff/20001/tests/language/illegal_initializer_test.dart File tests/language/illegal_initializer_test.dart (right): https://codereview.chromium.org/107103007/diff/20001/tests/language/illegal_initializer_test.dart#newcode11 tests/language/illegal_initializer_test.dart:11: ...

7 years ago (2013-12-18 08:25:58 UTC) #1

karlklose

Thanks, Florian. https://codereview.chromium.org/107103007/diff/20001/tests/language/illegal_initializer_test.dart File tests/language/illegal_initializer_test.dart (right): https://codereview.chromium.org/107103007/diff/20001/tests/language/illegal_initializer_test.dart#newcode11 tests/language/illegal_initializer_test.dart:11: : super.foo /// 01: compile-time error Changed ...

7 years ago (2013-12-18 10:46:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r31219 (presubmit successful).

Expand Messages | Collapse Messages

Issue 107103007: Emit a compile-time error for initializers of the form this.foo and super.foo. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Improved test. #

Messages