Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1070293004: Use UnaryOperator and BinaryOperator in ConstantSystem. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use UnaryOperator and BinaryOperator in ConstantSystem. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45248

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Rebased #

Patch Set 4 : Reinsert from bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -88 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 7 chunks +15 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 2 chunks +26 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 4 chunks +63 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 7 chunks +30 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/docgen/lib/src/models/model_helpers.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
5 years, 8 months ago (2015-04-17 13:00:44 UTC) #4
karlklose
LGTM. https://codereview.chromium.org/1070293004/diff/60001/pkg/compiler/lib/src/resolution/operators.dart File pkg/compiler/lib/src/resolution/operators.dart (right): https://codereview.chromium.org/1070293004/diff/60001/pkg/compiler/lib/src/resolution/operators.dart#newcode201 pkg/compiler/lib/src/resolution/operators.dart:201: /// The operators && and || which are ...
5 years, 8 months ago (2015-04-17 13:27:38 UTC) #5
Johnni Winther
5 years, 8 months ago (2015-04-17 17:53:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:100001) manually as 45248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698