Issue 107003007: Adding Angular's DI package & Dart unittests which test it.

Issue 107003007: Adding Angular's DI package & Dart unittests which test it. (Closed)

Created:
7 years ago by blois

Modified:
7 years ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding Angular's DI package & Dart unittests which test it. The non-Angular files which are being modified with this CL are: pkg/third_party/di/test/di_test.dart third_party/pkg/README third_party/pkg/di/update.sh DI is sync'd to revision 297d20694808a060c5275235aa3399dce7b87943. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=31361

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1795 lines, -6 lines)			Patch
A +	pkg/third_party/di_tests/di_test.dart	View	1	1 chunk	+9 lines, -6 lines	0 comments	Download
A	third_party/pkg/README	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/.gitignore	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/Gruntfile.coffee	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/LICENSE	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/README.md	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/TODO	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/benchmark/dynamic_injector_benchmark.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/benchmark/injector_benchmark_common.dart	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/benchmark/module_benchmark.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/benchmark/static_injector_benchmark.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/bin/generator.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/annotations.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/di.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/dynamic_injector.dart	View		1 chunk	+64 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/errors.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/generator.dart	View		1 chunk	+330 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/injector.dart	View		1 chunk	+219 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/mirrors.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/module.dart	View		1 chunk	+148 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/reflected_type.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/lib/static_injector.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/package.json	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/pubspec.yaml	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/run-benchmarks.sh	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/run-tests.sh	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/test/fixed-unittest.dart	View		1 chunk	+108 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/test/main.dart	View		1 chunk	+519 lines, -0 lines	0 comments	Download
A	third_party/pkg/di/test_tf_gen.sh	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	third_party/pkg/update_di.sh	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/107003007/diff/50001/pkg/third_party/di/test/di_test.dart File pkg/third_party/di/test/di_test.dart (right): https://codereview.chromium.org/107003007/diff/50001/pkg/third_party/di/test/di_test.dart#newcode6 pkg/third_party/di/test/di_test.dart:6: library angular.di.test; just to document what we discussed - ...

7 years ago (2013-12-20 23:40:19 UTC) #2

blois

7 years ago (2013-12-21 00:00:10 UTC) #3

https://codereview.chromium.org/107003007/diff/50001/pkg/third_party/di/test/...
File pkg/third_party/di/test/di_test.dart (right):

https://codereview.chromium.org/107003007/diff/50001/pkg/third_party/di/test/...
pkg/third_party/di/test/di_test.dart:6: library angular.di.test;
On 2013/12/20 23:40:20, Siggi Cherem (dart-lang) wrote:
> just to document what we discussed - let's rename pkg/third_party/di/ to
> pkg/third_party/di_test/
> 
> that way the symlink in packages/ always resolves to third_party/pkg/di/
> 
> Also, we might want to add a pubspec.yaml file to declare the dependency on
'di'
> explicitly, but also to indicate that this is not intended to be published.
> (e.g. put a comment of why there shouldn't be a 'version' entry)

Done. Skipped the pubspec.yaml as it doesn't technically have a dependency on
di, since it needs to use the relative path to access the test files.

https://codereview.chromium.org/107003007/diff/50001/third_party/pkg/README
File third_party/pkg/README (right):

https://codereview.chromium.org/107003007/diff/50001/third_party/pkg/README#n...
third_party/pkg/README:4: To update package di run di/update.sh from a git
enlistment.
On 2013/12/20 23:40:20, Siggi Cherem (dart-lang) wrote:
> another option would be to use a gyp dependency. maybe add a TODO? I think
> Rico/Martin mentioned that you can setup a mirror to make access fast in the
> bots.

Added a todo for the GYP dependency.

https://codereview.chromium.org/107003007/diff/50001/third_party/pkg/di/updat...
File third_party/pkg/di/update.sh (right):

https://codereview.chromium.org/107003007/diff/50001/third_party/pkg/di/updat...
third_party/pkg/di/update.sh:20: git pull --rebase origin master
On 2013/12/20 23:40:20, Siggi Cherem (dart-lang) wrote:
> do we expect to have patches in this repo? if not, we could simply delete the
> entire folder and download the latest version (possibly from pub instead of
> github)
> 
> Thoughts?

Done.

Message was sent while issue was closed.

Committed patchset #2 manually as r31361 (presubmit successful).

Expand Messages | Collapse Messages