Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1070023002: Propagate bailout messages from the CPS IR backends. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)
Modified:
5 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Propagate bailout messages from the CPS IR backends. If there is a bailout message, propagate it out. BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=45007

Patch Set 1 #

Patch Set 2 : Add another giveup method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 7 chunks +31 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-09 10:48:44 UTC) #2
asgerf
LGTM! This has been bothering me for so long.
5 years, 8 months ago (2015-04-09 10:50:20 UTC) #3
Kevin Millikin (Google)
It turns out that there was a reason that giveup was a library-level function instead ...
5 years, 8 months ago (2015-04-09 11:14:38 UTC) #4
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-09 13:34:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698