Issue 1069983005: Model 'await for' as an explicit node in tree and fix its handling.

Issue 1069983005: Model 'await for' as an explicit node in tree and fix its handling. (Closed)

Created:
5 years, 8 months ago by herhut

Modified:
5 years, 8 months ago

Reviewers:
Johnni Winther, floitsch

CC:
reviews_dartlang.org, sigurdm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Model 'await for' as an explicit node in tree and fix its handling. BUG= http://dartbug.com/23119 R=floitsch@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45053 Reverted: https://code.google.com/p/dart/source/detail?r=45057 Committed: https://code.google.com/p/dart/source/detail?r=45059

Patch Set 1 : #

Patch Set 2 : fix failing assertion rebase #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -59 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	1	1 chunk	+6 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/inferrer_visitor.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View	1	3 chunks	+38 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_graph_nodes.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View	1	3 chunks	+23 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/registry.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/scanner/listener.dart	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	1	2 chunks	+2 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/nodes.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree/nodes.dart	View		6 chunks	+36 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/tree/prettyprint.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/tree/unparser.dart	View		1 chunk	+17 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/typechecker.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/use_unused_api.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

herhut

Committed patchset #1 (id:20001) manually as 45053 (presubmit successful).

5 years, 8 months ago (2015-04-10 08:17:23 UTC) #6

herhut

PTAL the only change not due to rebasing is in simple_types_inferrer and it is very ...

5 years, 8 months ago (2015-04-10 10:20:43 UTC) #7

herhut

5 years, 8 months ago (2015-04-10 10:25:18 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as 45059 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages