Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 106993002: Revert "Change SDK/DartEditor versioning scheme to semantic versions." (Closed)

Created:
7 years ago by kustermann
Modified:
7 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Change SDK/DartEditor versioning scheme to semantic versions." +Revert "Remove pub tests for non-semantic SDK versions" This is causing build failures on dartium. Need to investigate. Committed: https://code.google.com/p/dart/source/detail?r=30908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -145 lines) Patch
M dart/editor/build/build.py View 1 chunk +0 lines, -3 lines 0 comments Download
M dart/editor/tools/features/com.google.dart.eclipse.feature_releng/build.properties View 5 chunks +11 lines, -11 lines 0 comments Download
M dart/editor/tools/features/com.google.dart.eclipse.feature_releng/build.xml View 2 chunks +2 lines, -8 lines 0 comments Download
M dart/editor/tools/features/com.google.dart.tools.deploy.feature_releng/build.properties View 1 chunk +1 line, -1 line 0 comments Download
M dart/editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml View 2 chunks +4 lines, -9 lines 0 comments Download
M dart/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/DartToolsPlugin.java View 1 chunk +5 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/sdk.dart View 3 chunks +30 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A dart/sdk/lib/_internal/pub/test/sdk_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/pub/test/version_solver_test.dart View 4 chunks +26 lines, -5 lines 0 comments Download
M dart/tools/VERSION View 1 chunk +2 lines, -28 lines 0 comments Download
M dart/tools/create_editor.py View 1 chunk +2 lines, -3 lines 0 comments Download
M dart/tools/create_windows_installer.py View 1 chunk +9 lines, -14 lines 0 comments Download
M dart/tools/utils.py View 4 chunks +41 lines, -61 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years ago (2013-12-05 19:05:31 UTC) #1
kustermann
Committed patchset #1 manually as r30908 (presubmit successful).
7 years ago (2013-12-05 19:06:06 UTC) #2
Bob Nystrom
7 years ago (2013-12-05 20:13:11 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698