Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1069413003: Fix pub test that broke with changes in dart:convert (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, ricow1, kevmoo
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix pub test that broke with changes in dart:convert (dart:convert no longer escapes '/' since https://code.google.com/p/dart/source/detail?r=45003) R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=45017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/pub/test/serve/404_page_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-09 16:06:25 UTC) #2
kevmoo
lgtm
5 years, 8 months ago (2015-04-09 16:18:37 UTC) #4
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-09 16:23:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45017 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698