Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1068233002: Revert "Extract CallStructure from Selector." (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Extract CallStructure from Selector." This reverts commit r44960. BUG= Committed: https://code.google.com/p/dart/source/detail?r=44961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -615 lines) Patch
M pkg/analyzer2dart/lib/src/modely.dart View 4 chunks +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 5 chunks +3 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/common.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 13 chunks +24 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 4 chunks +10 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 11 chunks +19 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 11 chunks +43 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 4 chunks +14 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 3 chunks +10 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +9 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 16 chunks +31 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 8 chunks +302 lines, -354 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 8 months ago (2015-04-08 10:37:25 UTC) #2
floitsch
LGTM.
5 years, 8 months ago (2015-04-08 10:37:44 UTC) #3
Johnni Winther
5 years, 8 months ago (2015-04-08 10:40:03 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 44961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698