Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 106793007: Convert InstantiatedTypeArguments to TypeArguments upon canonicalization. (Closed)

Created:
7 years ago by regis
Modified:
7 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Jacob
Visibility:
Public.

Description

Convert InstantiatedTypeArguments to TypeArguments upon canonicalization. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31325

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M runtime/vm/object.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
This fixes the crash reported by Jacob in a Dartium test.
7 years ago (2013-12-19 10:42:07 UTC) #1
Ivan Posva
LGTM -ip
7 years ago (2013-12-19 17:34:49 UTC) #2
regis
7 years ago (2013-12-20 09:20:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698