Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1067903002: Changes in analyzer needed for dev_compiler (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Changes in analyzer needed for dev_compiler R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44945

Patch Set 1 : #

Patch Set 2 : fixes analyzer errors in tests (implement added API)" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -32 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 15 chunks +35 lines, -28 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-07 18:09:31 UTC) #4
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-07 19:13:25 UTC) #5
Siggi Cherem (dart-lang)
thanks! FYI - I fixed a couple tests files after running the tests. (minor change ...
5 years, 8 months ago (2015-04-07 19:56:23 UTC) #6
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-07 19:58:20 UTC) #7
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-07 20:06:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as 44945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698