Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1067533003: cps-ir: Handle factories and redirecting constructors with JS backend. (Closed)

Created:
5 years, 8 months ago by asgerf
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

cps-ir: Handle factories and redirecting constructors with JS backend. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45128

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : One more test #

Patch Set 4 : Test case where effective target changes the type #

Patch Set 5 : Minor fix in test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -17 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 4 chunks +37 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
asgerf
5 years, 8 months ago (2015-04-13 14:27:35 UTC) #2
karlklose
Does this handle redirecting factories like class C<T> implements D {} class D { factory ...
5 years, 8 months ago (2015-04-14 07:22:45 UTC) #3
asgerf
Good point, and yes it handles it. Added a test case for it.
5 years, 8 months ago (2015-04-14 07:51:17 UTC) #4
karlklose
LGTM.
5 years, 8 months ago (2015-04-14 08:15:23 UTC) #5
asgerf
5 years, 8 months ago (2015-04-14 08:25:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 45128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698