Issue 1066613004: Remove embedder-package scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1066613004: Remove embedder-package scheme (Closed)

Created:
5 years, 8 months ago by Cutch

Modified:
5 years, 8 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Remove embedder-package scheme - Soon mojo embedder private packages will be imported with a 'dart:_' prefixes. - Add an explicit test of transitive private library access. This ensures that imports of 'dart:embedder_private_packages' cannot access anything imported within it. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45169

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	runtime/bin/builtin.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
	A	tests/language/transitive_private_library_access_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 45169 (presubmit successful).

5 years, 8 months ago (2015-04-15 15:49:57 UTC) #4

Message was sent while issue was closed.

Thanks!

-Ivan

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages