Fix order of parameters in intercepted generative constructor body.

Fix order of parameters in intercepted generative constructor body.

When the receiver parameter is inserted at the front of the parameter list, some parameters may have already been inserted and others will be inserted later.
If none have already been inserted, then the subsequent parameters were being inserted in front of the receiver parameter. This is fixed by marking the receiver as the lastAddedParameter if it is the only one. This did not seem to affect 'this', presumably because the position of 'this' is immaterial since it is always removed from the JS function parameters.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45048

[sra1, 2015-04-08 02:16:17]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2015-04-08 02:21:44]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-04-08 17:52:42]

could we add a test too? Maybe just use the code in
https://code.google.com/p/dart/issues/detail?id=23127 ?

https://codereview.chromium.org/1066303002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1066303002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:93: toString() => 'SyntheticLocal($name)';
I assume this was just for debugging?

https://codereview.chromium.org/1066303002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:393:
builder.graph.entry.addAfter(directLocals[closureData.thisLocal], value);
any reason to move these above the explicitReceiverParameter assignment? Or the
order doesn't matter here?

[sra1, 2015-04-09 04:37:09]

PTAL

As explained before, no other combination of kinds of argument tickle the bug.

https://codereview.chromium.org/1066303002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1066303002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:93: toString() => 'SyntheticLocal($name)';
On 2015/04/08 17:52:42, Siggi Cherem (dart-lang) wrote:
> I assume this was just for debugging?

Yes.

https://codereview.chromium.org/1066303002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:393:
builder.graph.entry.addAfter(directLocals[closureData.thisLocal], value);
On 2015/04/08 17:52:42, Siggi Cherem (dart-lang) wrote:
> any reason to move these above the explicitReceiverParameter assignment? Or
the
> order doesn't matter here?

No reason. I'll put them back in the original order.

[Siggi Cherem (dart-lang), 2015-04-09 16:15:19]

lgtm!

Fantastic, thanks Stephen!

[sra1, 2015-04-10 03:18:12]

Committed patchset #2 (id:40001) manually as 45048 (presubmit successful).