Issue 106623006: Fix bug in double unboxing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106623006: Fix bug in double unboxing. (Closed)

Created:
7 years ago by Florian Schneider

Modified:
7 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in double unboxing. The state bit that record if a field is unboxed or not has to be checked in unoptimized code as well, since that code does not change when deoptimizing. I also compacted the kind_bits bit field in the Field class to start from bit 0. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31229

Patch Set 1 #

Patch Set 2 : fixed mips code #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years ago (2013-12-18 15:46:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31229 (presubmit successful).

Expand Messages | Collapse Messages