Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1066203004: Fix MethodMirror.source when the method is on the first line in a script. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix MethodMirror.source when the method is on the first line in a script. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44957

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M runtime/vm/object.cc View 2 chunks +7 lines, -5 lines 0 comments Download
A tests/lib/mirrors/method_mirror_source_other.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib/mirrors/method_mirror_source_test.dart View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-08 00:36:35 UTC) #2
siva
lgtm
5 years, 8 months ago (2015-04-08 00:47:52 UTC) #3
rmacnak
5 years, 8 months ago (2015-04-08 01:03:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698