Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1066043002: Make sure declared upper bounds are resolved when finalizing a type containing a (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make sure declared upper bounds are resolved when finalizing a type containing a cycle via bounds (issue 23089). Add regression test. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44956

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
A tests/language/regress_23089_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
5 years, 8 months ago (2015-04-07 19:32:32 UTC) #2
siva
lgtm
5 years, 8 months ago (2015-04-08 00:57:49 UTC) #3
regis
5 years, 8 months ago (2015-04-08 00:59:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r44956 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698