Issue 1065773003: Fix mint shifting by zero on MIPS (issue 23117).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1065773003: Fix mint shifting by zero on MIPS (issue 23117). (Closed)

Created:
5 years, 8 months ago by regis

Modified:
5 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix mint shifting by zero on MIPS (issue 23117). Add regression test. Restore formatting space dropped by mistake in simulator tracing output. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45042

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -9 lines)			Patch
M	runtime/vm/intermediate_language_mips.cc	View		4 chunks	+13 lines, -6 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/vm/regress_23117_vm_test.dart	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

zra

lgtm Does this fix a test? Is a regression test needed for this bug?

5 years, 8 months ago (2015-04-09 22:09:34 UTC) #3

regis

On 2015/04/09 22:09:34, zra wrote: > lgtm > > Does this fix a test? Is ...

5 years, 8 months ago (2015-04-09 22:18:39 UTC) #4

regis

5 years, 8 months ago (2015-04-09 22:50:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r45042 (presubmit successful).