Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1065303003: Fix auto-refresh in Heap profile. (Closed)

Created:
5 years, 8 months ago by koda
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org, kustermann
Visibility:
Public.

Description

Fix auto-refresh in Heap profile. To avoid lag when the profile page cannot keep up with the GC events, keep at most one outstanding auto-refresh request (but make sure to refresh up to and including the latest GC). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M runtime/observatory/lib/src/elements/heap_profile.dart View 2 chunks +24 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 8 months ago (2015-04-09 01:48:49 UTC) #1
Cutch
lgtm
5 years, 8 months ago (2015-04-09 13:41:15 UTC) #2
koda
5 years, 8 months ago (2015-04-09 16:01:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698