Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1065303002: Add assertion for variable index of reused potentially reused AST nodes. (Closed)

Created:
5 years, 8 months ago by Florian Schneider
Modified:
5 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add assertion for variable index of reused potentially reused AST nodes. The flow graph inliner reuses the callee ASTs, therefore nodes may already have an index assigned. Make sure it matches. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 8 months ago (2015-04-08 13:13:35 UTC) #2
hausner
lgtm
5 years, 8 months ago (2015-04-08 15:35:00 UTC) #3
Florian Schneider
5 years, 8 months ago (2015-04-09 09:08:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698