Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1065063002: suggest loadLibrary is import is deferred (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

suggest loadLibrary is import is deferred BUG=dartbug.com/23108 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44953

Patch Set 1 #

Patch Set 2 : merge and remove unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 3 chunks +19 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-07 22:12:55 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-07 22:15:11 UTC) #3
danrubel
5 years, 8 months ago (2015-04-07 22:20:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698