Issue 1064783002: CssStyleDeclaration performance work

Issue 1064783002: CssStyleDeclaration performance work (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

CssStyleDeclaration performance work Cache browser prefix detection to avoid repeated camelCasing. Remove IE9 compatibility code. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=44951

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -56 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+21 lines, -15 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+14 lines, -3 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		8 chunks	+0 lines, -8 lines	0 comments	Download
M	tools/dom/scripts/css_code_generator.py	View	2	2 chunks	+26 lines, -15 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	2	2 chunks	+26 lines, -15 lines	0 comments	Download

Total messages: 7 (1 generated)

sra1

Committed patchset #1 (id:1) manually as 44931 (presubmit successful).

5 years, 8 months ago (2015-04-07 01:23:03 UTC) #3

sra1

On 2015/04/07 01:23:03, sra1 wrote: > Committed patchset #1 (id:1) manually as 44931 (presubmit successful). ...

5 years, 8 months ago (2015-04-07 01:55:43 UTC) #4

sra1

The co19 results make sense: The IE9 compatibility code's try-catch was swallowing expected exceptions on ...

5 years, 8 months ago (2015-04-07 03:17:51 UTC) #5

Alan Knight

LGTM, but make sure you re-run the generation scripts before committing, I've made other changes ...

5 years, 8 months ago (2015-04-07 18:11:57 UTC) #6

sra1

5 years, 8 months ago (2015-04-07 21:34:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 44951 (presubmit successful).