Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1064273002: pkg/path: Add type annotations to top-level and static fields. (Closed)

Created:
5 years, 8 months ago by kevmoo
Modified:
5 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, sethladd
Base URL:
https://github.com/dart-lang/path.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type annotations to top-level and static fields. R=nweiz@google.com Committed: https://github.com/dart-lang/path/commit/2f3dcdec32011f1bc41194ae3640d6d9292a7096

Patch Set 1 #

Total comments: 4

Patch Set 2 : version nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/path.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/style.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
Having a dynamic return type implies that the type of these fields cannot be counted ...
5 years, 8 months ago (2015-04-07 23:19:53 UTC) #2
nweiz
https://codereview.chromium.org/1064273002/diff/1/lib/path.dart File lib/path.dart (right): https://codereview.chromium.org/1064273002/diff/1/lib/path.dart#newcode63 lib/path.dart:63: final Context url = new Context(style: Style.url); I don't ...
5 years, 8 months ago (2015-04-09 18:41:24 UTC) #3
kevmoo
https://codereview.chromium.org/1064273002/diff/1/lib/path.dart File lib/path.dart (right): https://codereview.chromium.org/1064273002/diff/1/lib/path.dart#newcode63 lib/path.dart:63: final Context url = new Context(style: Style.url); On 2015/04/09 ...
5 years, 8 months ago (2015-04-09 19:07:55 UTC) #4
nweiz
lgtm
5 years, 8 months ago (2015-04-09 20:09:20 UTC) #5
kevmoo
5 years, 8 months ago (2015-04-09 20:10:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2f3dcdec32011f1bc41194ae3640d6d9292a7096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698