Issue 1064053007: Revert "Change ListIterator to only check for concurrent modification at each iteration"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1064053007: Revert "Change ListIterator to only check for concurrent modification at each iteration" (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan, Vyacheslav Egorov (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Revert "Change ListIterator to only check for concurrent modification at each iteration" Revert "Fix ListIterator.iterator function hash for VM." This is not as easy to optimize for dart2js as initially thought. Revert this change while we discuss. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45216

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -56 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_array.dart	View	1 chunk	+17 lines, -14 lines	0 comments	Download
M	sdk/lib/internal/iterable.dart	View	1 chunk	+11 lines, -14 lines	0 comments	Download
M	tests/corelib/iterable_fold_test.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/corelib/iterable_reduce_test.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/corelib/json_map_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/list_test.dart	View	1 chunk	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

5 years, 8 months ago (2015-04-16 18:53:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45216 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages