Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1063613002: Add an analysis server option to enable null-aware-operator support. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add an analysis server option to enable null-aware-operator support. The option may be enabled in editor by setting the tracing option "experimental/nullAwareOperators" (in com.google.dart.tools.core) to true. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44909

Patch Set 1 #

Patch Set 2 : Roll the analysis server JSON API version. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -29 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java View 11 chunks +29 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 6 chunks +6 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/.options View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCoreDebug.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 1 chunk +1 line, -0 lines 2 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +12 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 9 chunks +21 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 5 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paul Berry
5 years, 8 months ago (2015-04-05 22:06:49 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1063613002/diff/20001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java (right): https://codereview.chromium.org/1063613002/diff/20001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java#newcode269 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java:269: DartCoreDebug.ENABLE_DEFERRED_LOADING, Shouldn't this also always be "true"?
5 years, 8 months ago (2015-04-06 13:53:41 UTC) #3
Paul Berry
https://codereview.chromium.org/1063613002/diff/20001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java (right): https://codereview.chromium.org/1063613002/diff/20001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java#newcode269 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java:269: DartCoreDebug.ENABLE_DEFERRED_LOADING, On 2015/04/06 13:53:41, Brian Wilkerson wrote: > Shouldn't ...
5 years, 8 months ago (2015-04-06 14:35:27 UTC) #4
Paul Berry
Committed patchset #2 (id:20001) manually as 44909 (presubmit successful).
5 years, 8 months ago (2015-04-06 14:53:17 UTC) #5
jwren
5 years, 8 months ago (2015-04-06 16:11:04 UTC) #6
Message was sent while issue was closed. 
On 2015/04/06 14:53:17, Paul Berry wrote:
> Committed patchset #2 (id:20001) manually as 44909 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698