Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1063603004: Fix typo in test, add check of error thrown. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix typo in test, add check of error thrown. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M sdk/lib/core/uri.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/uri_file_test.dart View 3 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-17 10:53:07 UTC) #2
karlklose
LGTM.
5 years, 8 months ago (2015-04-17 10:55:14 UTC) #3
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-17 10:55:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45233 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698