Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1063213002: Make SVGValidator reject foreignobject tags, not just their contents. Fixes Firefox inconsistency (Closed)

Created:
5 years, 8 months ago by Alan Knight
Modified:
5 years, 8 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make SVGValidator reject foreignobject tags, not just their contents. Fixes Firefox inconsistency BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44949

Patch Set 1 #

Patch Set 2 : Removed status file entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/html/node_validator_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/dom/src/NodeValidatorBuilder.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
We already delete the whole contents, we may as well delete the foreignobject tag as ...
5 years, 8 months ago (2015-04-07 20:02:38 UTC) #2
terry
lgtm just needs status file enabled.
5 years, 8 months ago (2015-04-07 20:39:47 UTC) #3
Alan Knight
5 years, 8 months ago (2015-04-07 20:59:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698