Extract CallStructure from Selector.

Extract CallStructure from Selector.

This should be used for static invocation so that Selector is only for dynamic invocations.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44960

Reverted: https://code.google.com/p/dart/source/detail?r=44961

Committed: https://code.google.com/p/dart/source/detail?r=44991

[Johnni Winther, 2015-04-07 07:50:40]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-04-07 14:09:21]

LGTM.

https://codereview.chromium.org/1062913003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/1062913003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:545: static Map<int, List<Selector>>
canonicalizedValues =
To think about:
I would like to remove this static state.

If we still want to canonicalize I see two options:
- compiler.selectors.create(...)
- new Selector(..., compiler)

https://codereview.chromium.org/1062913003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:552: List<Selector> list =
canonicalizedValues.putIfAbsent(hashCode,
Not your code (and not for this CL):

I wonder if this wouldn't be easier (and as fast, as follows): 

===
Selector selector = new Selector.internal(
    kind, name, callStructure, hashCode);
Selector canonicalized = canonicalizedValues[selector];
if (canonicalized != null) return canonicalized;
canonicalizedValues[selector] = selector;
return selector;
===

Afaics the number of allocations is the same (or fewer), and the search should
be faster.

[Johnni Winther, 2015-04-08 09:32:41]

Committed patchset #2 (id:20001) manually as 44960 (presubmit successful).

[Johnni Winther, 2015-04-08 12:25:11]

https://codereview.chromium.org/1062913003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/1062913003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:545: static Map<int, List<Selector>>
canonicalizedValues =
On 2015/04/07 14:09:21, floitsch wrote:
> To think about:
> I would like to remove this static state.
> 
> If we still want to canonicalize I see two options:
> - compiler.selectors.create(...)
> - new Selector(..., compiler)

Added a TODO.

https://codereview.chromium.org/1062913003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:552: List<Selector> list =
canonicalizedValues.putIfAbsent(hashCode,
On 2015/04/07 14:09:21, floitsch wrote:
> Not your code (and not for this CL):
> 
> I wonder if this wouldn't be easier (and as fast, as follows): 
> 
> ===
> Selector selector = new Selector.internal(
>     kind, name, callStructure, hashCode);
> Selector canonicalized = canonicalizedValues[selector];
> if (canonicalized != null) return canonicalized;
> canonicalizedValues[selector] = selector;
> return selector;
> ===
> 
> Afaics the number of allocations is the same (or fewer), and the search should
> be faster.

Add a TODO.

[Johnni Winther, 2015-04-08 12:36:13]

PTAL at the latest patch

[floitsch, 2015-04-08 14:19:22]

LGTM.

[Johnni Winther, 2015-04-09 07:45:12]

PTAL the last fix of the unittest. It's committed TBR.

[Johnni Winther, 2015-04-09 07:45:51]

Committed patchset #6 (id:100001) manually as 44991 (presubmit successful).

[floitsch, 2015-04-09 08:39:05]

Still LGTM.