Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1062753004: Fix bigint division (issue 23238). (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix bigint division (issue 23238). Add regression test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45253

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M runtime/lib/bigint.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download
A tests/language/vm/regress_23238_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 8 months ago (2015-04-17 20:11:56 UTC) #2
zra
lgtm with question https://codereview.chromium.org/1062753004/diff/1/runtime/lib/bigint.dart File runtime/lib/bigint.dart (right): https://codereview.chromium.org/1062753004/diff/1/runtime/lib/bigint.dart#newcode1146 runtime/lib/bigint.dart:1146: } Do you need to fix ...
5 years, 8 months ago (2015-04-17 20:19:28 UTC) #3
regis
Good Catch! Thanks, Regis https://codereview.chromium.org/1062753004/diff/1/runtime/lib/bigint.dart File runtime/lib/bigint.dart (right): https://codereview.chromium.org/1062753004/diff/1/runtime/lib/bigint.dart#newcode1146 runtime/lib/bigint.dart:1146: } On 2015/04/17 20:19:28, zra ...
5 years, 8 months ago (2015-04-17 20:25:52 UTC) #4
regis
5 years, 8 months ago (2015-04-17 20:30:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r45253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698