Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1062683004: Preliminary safari support. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 2

Patch Set 3 : update #

Total comments: 1

Patch Set 4 : Polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -17 lines) Patch
M CHANGELOG.md View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M README.md View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/backend/test_platform.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M lib/src/executable.dart View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A lib/src/runner/browser/safari.dart View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
M lib/src/runner/browser/server.dart View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M test/runner/browser/runner_test.dart View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
A + test/runner/browser/safari_test.dart View 1 2 3 6 chunks +14 lines, -14 lines 0 comments Download
M test/runner/runner_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
I didn't see Safari in test/runner/browser/runner_test.dart – I added a couple get an exit code ...
5 years, 8 months ago (2015-04-15 22:42:34 UTC) #2
kevmoo
new File(redirect).writeAsStringSync( "<script>location = " + JSON.encode(url.toString()) + "</script>"); https://codereview.chromium.org/1062683004/diff/20001/lib/src/runner/browser/safari.dart File lib/src/runner/browser/safari.dart (right): https://codereview.chromium.org/1062683004/diff/20001/lib/src/runner/browser/safari.dart#newcode7 lib/src/runner/browser/safari.dart:7: ...
5 years, 8 months ago (2015-04-15 22:54:29 UTC) #3
kevmoo
all matcher tests pass! https://codereview.chromium.org/1062683004/diff/40001/lib/src/runner/browser/safari.dart File lib/src/runner/browser/safari.dart (right): https://codereview.chromium.org/1062683004/diff/40001/lib/src/runner/browser/safari.dart#newcode8 lib/src/runner/browser/safari.dart:8: import 'dart:io'; still need dart:convert
5 years, 8 months ago (2015-04-15 23:03:22 UTC) #4
nweiz
This is ready for review now.
5 years, 8 months ago (2015-04-15 23:44:41 UTC) #5
kevmoo
lgtm
5 years, 8 months ago (2015-04-16 00:02:01 UTC) #6
nweiz
5 years, 8 months ago (2015-04-16 00:11:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
98a8dd7f74153cc449da8a64214616ed4d81e750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698