Issue 1062523003: Add support for --pub-serve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1062523003: Add support for --pub-serve. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add support for --pub-serve. Closes #47 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/144ab30a138e2186b6c7f3a25cde7f6c0b63aa8a

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+624 lines, -36 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	README.md	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A	lib/pub_serve.dart	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	lib/src/executable.dart	View	4 chunks	+53 lines, -1 line	0 comments	Download
M	lib/src/runner/browser/server.dart	View	9 chunks	+109 lines, -17 lines	0 comments	Download
M	lib/src/runner/load_exception.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/src/runner/loader.dart	View	7 chunks	+50 lines, -6 lines	0 comments	Download
M	lib/src/util/io.dart	View	3 chunks	+16 lines, -2 lines	1 comment	Download
M	pubspec.yaml	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/io.dart	View	3 chunks	+22 lines, -0 lines	0 comments	Download
A	test/runner/pub_serve_test.dart	View	1 chunk	+249 lines, -0 lines	0 comments	Download
M	test/runner/runner_test.dart	View	1 chunk	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1062523003/diff/1/lib/src/util/io.dart File lib/src/util/io.dart (right): https://codereview.chromium.org/1062523003/diff/1/lib/src/util/io.dart#newcode21 lib/src/util/io.dart:21: /// The version of the Dart SDK currently ...

5 years, 8 months ago (2015-04-03 22:55:54 UTC) #2

nweiz

5 years, 8 months ago (2015-04-03 23:26:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
144ab30a138e2186b6c7f3a25cde7f6c0b63aa8a (presubmit successful).

Expand Messages | Collapse Messages