Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1062523002: Use evaluate:source as the uri of eval scripts instead of the empty string, so e.g., package:stack… (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use evaluate:source as the uri of eval scripts instead of the empty string, so e.g., package:stack_trace will tolerate them. BUG=http://dartbug.com/23006 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44884

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/object.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-03 18:09:09 UTC) #2
siva
lgtm https://codereview.chromium.org/1062523002/diff/1/runtime/vm/symbols.h File runtime/vm/symbols.h (right): https://codereview.chromium.org/1062523002/diff/1/runtime/vm/symbols.h#newcode337 runtime/vm/symbols.h:337: V(GeneratedSourceUri, "generated:source") \ Why not call it evaluate:source ...
5 years, 8 months ago (2015-04-03 18:26:57 UTC) #3
rmacnak
https://codereview.chromium.org/1062523002/diff/1/runtime/vm/symbols.h File runtime/vm/symbols.h (right): https://codereview.chromium.org/1062523002/diff/1/runtime/vm/symbols.h#newcode337 runtime/vm/symbols.h:337: V(GeneratedSourceUri, "generated:source") \ On 2015/04/03 18:26:57, siva wrote: > ...
5 years, 8 months ago (2015-04-03 18:37:17 UTC) #4
rmacnak
5 years, 8 months ago (2015-04-03 18:38:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698