Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1062343002: improve parser recovery for import directives (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

improve parser recovery for import directives BUG=dartbug.com/23108 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44968

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danrubel
5 years, 8 months ago (2015-04-07 22:24:37 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1062343002/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/1062343002/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode5973 pkg/analyzer/lib/src/generated/parser.dart:5973: _tokenMatchesKeyword(_peek(), Keyword.AS)) { We might want to allow ...
5 years, 8 months ago (2015-04-07 23:09:14 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as 44968 (presubmit successful).
5 years, 8 months ago (2015-04-08 13:37:56 UTC) #4
danrubel
https://codereview.chromium.org/1062343002/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/1062343002/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode5973 pkg/analyzer/lib/src/generated/parser.dart:5973: _tokenMatchesKeyword(_peek(), Keyword.AS)) { On 2015/04/07 23:09:14, Brian Wilkerson wrote: ...
5 years, 8 months ago (2015-04-08 14:51:26 UTC) #5
danrubel
5 years, 8 months ago (2015-04-08 15:39:22 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1062343002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/parser_test.dart (right):

https://codereview.chromium.org/1062343002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/parser_test.dart:3272: void
test_importDirectivePartial() {
On 2015/04/07 23:09:14, Brian Wilkerson wrote:
> Seems more common cases would be both
>   "import 'b.dart' d"
> and
>   "import 'b.dart' d import"

Good point. I'll add tests for those situations.

Powered by Google App Engine
This is Rietveld 408576698